Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEKPLS version with SK Learn PLS #357

Conversation

vikram-s-narayan
Copy link
Contributor

This is just a draft pull request. Still need to:

  1. Replace SK Learn's PLS regressor with pure Julia alternative
  2. Add 2D equivalent for box-behnken design
  3. Add the add_point function
  4. Add more tests
  5. Add documentation
  6. Add hyperparameter optimization for theta

@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #357 (25aa597) into master (21ffe1f) will decrease coverage by 5.16%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   77.56%   72.39%   -5.17%     
==========================================
  Files          15       16       +1     
  Lines        2050     2192     +142     
==========================================
- Hits         1590     1587       -3     
- Misses        460      605     +145     
Impacted Files Coverage Δ
src/GEKPLS.jl 0.00% <0.00%> (ø)
src/Optimization.jl 72.09% <0.00%> (-0.28%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@vikram-s-narayan
Copy link
Contributor Author

Closing this draft PR as I've now added a modified PLS to replace the SK Learn PLS (please see PR #359).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant